Address review: redact plant owner ids, cache-control, 400, DRY reset

- Security (2-model, security+correctness): the public payload zeroed
  Garden.OwnerID but referenced custom plants still carried Plant.OwnerID,
  leaking the owner's user id to anonymous viewers. Redact plant owner ids
  too, and assert it in the service test.
- Set Cache-Control: no-store on the public read so a capability-URL response
  isn't held in a shared proxy cache and always reflects the live garden.
- createShareLink now 400s on a present-but-malformed JSON body instead of
  silently enabling (an empty body still means enable-without-rotate).
- Extract the transient-editor-state reset into a shared resetTransient store
  action (3-model finding) and use it from PublicGardenPage.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01JdQpdYYsTgtkJBxbcpAszi

internal/api/public.go

@@ -1,6 +1,8 @@
 package api
 
 import (
+	"errors"
+	"io"
 	"net/http"
 
 	"github.com/gin-gonic/gin"
@@ -16,6 +18,10 @@ func (h *handlers) getPublicGarden(c *gin.Context) {
 		writeServiceError(c, err)
 		return
 	}
+	// The token is a capability in the URL: keep the response out of any shared
+	// proxy cache, and always serve the live garden (the owner may have edited or
+	// revoked it since the last view).
+	c.Header("Cache-Control", "no-store")
 	c.JSON(http.StatusOK, full)
 }
 
@@ -45,7 +51,12 @@ func (h *handlers) createShareLink(c *gin.Context) {
 	var req struct {
 		Rotate bool `json:"rotate"`
 	}
-	_ = c.ShouldBindJSON(&req)
+	// The body is optional (an empty body means enable-without-rotate), but a
+	// present-yet-malformed body is a client error, not a silent enable.
+	if err := c.ShouldBindJSON(&req); err != nil && !errors.Is(err, io.EOF) {
+		writeAPIError(c, http.StatusBadRequest, "INVALID_INPUT", "invalid request body")
+		return
+	}
 	link, err := h.svc.EnablePublicShareLink(c.Request.Context(), mustActor(c).ID, id, req.Rotate)
 	if err != nil {
 		writeServiceError(c, err)

internal/service/public.go

@@ -38,10 +38,14 @@ func (s *Service) PublicGarden(ctx context.Context, token string) (*FullGarden,
 	if err != nil {
 		return nil, err
 	}
-	// Minimize what an anonymous viewer learns: no role, and don't expose the
-	// owner's user id (the page renders fine without it).
+	// Minimize what an anonymous viewer learns: no role, and no owner user id —
+	// neither the garden's owner nor the owner of any referenced custom plant
+	// (built-ins already have a nil OwnerID). The page renders fine without them.
 	full.Garden.MyRole = ""
 	full.Garden.OwnerID = 0
+	for i := range full.Plants {
+		full.Plants[i].OwnerID = nil
+	}
 	return full, nil
 }
 

internal/service/public_test.go

@@ -84,6 +84,13 @@ func TestPublicShareLink(t *testing.T) {
 		t.Errorf("public full = %d objs / %d plops / %d plants, want 1/1/1",
 			len(full.Objects), len(full.Plantings), len(full.Plants))
 	}
+	// The referenced plant is the owner's custom plant; its OwnerID must be
+	// redacted so an anonymous viewer can't learn the owner's user id.
+	for _, pl := range full.Plants {
+		if pl.OwnerID != nil {
+			t.Errorf("public plant %d leaks OwnerID %d, want nil", pl.ID, *pl.OwnerID)
+		}
+	}
 
 	// Unknown / blank tokens are masked, never a distinct error.
 	for _, bad := range []string{"does-not-exist", "  ", ""} {