Change ShowBrowser from bool to *bool in BrowserOptions so nil means "don't override" in mergeOptions(), fixing the bug where it always overwrote the base value
Add extractor.Bool() helper for convenient *bool construction
Align NewInteractiveBrowser default browser from Chromium to Firefox, matching NewBrowser
Update README example and CLI flags for the *bool change
Test plan
go build ./... passes
go test ./... passes
go vet ./... passes
Verify mergeOptions no longer resets ShowBrowser to false when not explicitly set
## Summary
- Change `ShowBrowser` from `bool` to `*bool` in `BrowserOptions` so `nil` means "don't override" in `mergeOptions()`, fixing the bug where it always overwrote the base value
- Add `extractor.Bool()` helper for convenient `*bool` construction
- Align `NewInteractiveBrowser` default browser from Chromium to Firefox, matching `NewBrowser`
- Update README example and CLI flags for the `*bool` change
## Test plan
- [x] `go build ./...` passes
- [x] `go test ./...` passes
- [x] `go vet ./...` passes
- [ ] Verify `mergeOptions` no longer resets `ShowBrowser` to false when not explicitly set
Closes #15, #16
**Parent:** #31 (Phase 3, PR 7)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
- Change ShowBrowser from bool to *bool so nil means "don't override"
in mergeOptions(), fixing the bug where it always overwrote the base
- Add Bool() helper for convenient *bool construction
- Align NewInteractiveBrowser default from Chromium to Firefox to match
NewBrowser
- Update README example and CLI flags for the *bool change
Closes#15, #16
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Claude
merged commit 0df639abea into main2026-02-15 16:23:08 +00:00
Claude
deleted branch fix/merge-options-and-browser-defaults2026-02-15 16:23:08 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
ShowBrowserfromboolto*boolinBrowserOptionssonilmeans "don't override" inmergeOptions(), fixing the bug where it always overwrote the base valueextractor.Bool()helper for convenient*boolconstructionNewInteractiveBrowserdefault browser from Chromium to Firefox, matchingNewBrowser*boolchangeTest plan
go build ./...passesgo test ./...passesgo vet ./...passesmergeOptionsno longer resetsShowBrowserto false when not explicitly setCloses #15, #16
Parent: #31 (Phase 3, PR 7)
🤖 Generated with Claude Code