Playwright's Cookie type includes SameSite (Strict, Lax, None), but this field is lost during conversion in playwrightCookieToCookie() (playwright.go:80-89).
Impact
Low — the current use cases may not need SameSite. But for completeness, especially for the cookie jar's cookies.txt import/export, supporting this field would improve fidelity.
Fix
Add SameSite string to Cookie and update the conversion functions.
**Parent:** #3
## Description
The `Cookie` struct in `cookiejar.go:9-17` is missing the `SameSite` attribute:
```go
type Cookie struct {
Host string
Path string
Expires time.Time
Secure bool
HttpOnly bool
Name string
Value string
// Missing: SameSite
}
```
Playwright's `Cookie` type includes `SameSite` (`Strict`, `Lax`, `None`), but this field is lost during conversion in `playwrightCookieToCookie()` (`playwright.go:80-89`).
## Impact
Low — the current use cases may not need SameSite. But for completeness, especially for the cookie jar's `cookies.txt` import/export, supporting this field would improve fidelity.
## Fix
Add `SameSite string` to `Cookie` and update the conversion functions.
Work finished — added SameSite field to Cookie struct with SameSiteStrict, SameSiteLax, SameSiteNone constants. Playwright conversion functions updated. Merged in PR #42.
Work finished — added `SameSite` field to `Cookie` struct with `SameSiteStrict`, `SameSiteLax`, `SameSiteNone` constants. Playwright conversion functions updated. Merged in PR #42.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Parent: #3
Description
The
Cookiestruct incookiejar.go:9-17is missing theSameSiteattribute:Playwright's
Cookietype includesSameSite(Strict,Lax,None), but this field is lost during conversion inplaywrightCookieToCookie()(playwright.go:80-89).Impact
Low — the current use cases may not need SameSite. But for completeness, especially for the cookie jar's
cookies.txtimport/export, supporting this field would improve fidelity.Fix
Add
SameSite stringtoCookieand update the conversion functions.Starting work on this. Will add
SameSitefield toCookiestruct and update Playwright conversion functions.Work finished — added
SameSitefield toCookiestruct withSameSiteStrict,SameSiteLax,SameSiteNoneconstants. Playwright conversion functions updated. Merged in PR #42.Resolved by PR #42 — added
SameSitefield toCookiestruct and updated conversion functions.