fix: bug fixes, test coverage, and CI workflow
Some checks failed
CI / vet (push) Failing after 15s
CI / build (push) Failing after 30s
CI / test (push) Failing after 36s

- Fix Nodes.First() panic on empty slice (return nil)
- Fix ticker leak in archive.go (create once, defer Stop)
- Fix cookie path matching for empty and root paths
- Fix lost query params in google.go (u.Query().Set was discarded)
- Fix type assertion panic in useragents.go
- Fix dropped date parse error in powerball.go
- Remove unreachable dead code in megamillions.go and powerball.go
- Simplify document.go WaitForNetworkIdle, remove unused root field
- Remove debug fmt.Println calls across codebase
- Replace panic(err) with stderr+exit in all cmd/ programs
- Fix duckduckgo cmd: remove useless defer, return error on bad safesearch
- Fix archive cmd: ToConfig returns error instead of panicking
- Add 39+ unit tests across 6 new test files
- Add Gitea Actions CI workflow (build, test, vet in parallel)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-02-09 11:14:05 -05:00
parent e807dbb2ff
commit e7b7e78796
25 changed files with 868 additions and 117 deletions

View File

@@ -87,9 +87,8 @@ func main() {
},
}
err := cli.Run(context.Background(), os.Args)
if err != nil {
panic(err)
if err := cli.Run(context.Background(), os.Args); err != nil {
fmt.Fprintf(os.Stderr, "error: %v\n", err)
os.Exit(1)
}
}

View File

@@ -57,14 +57,17 @@ func deferClose(cl io.Closer) {
func (c Config) Search(ctx context.Context, b extractor.Browser, query string) ([]Result, error) {
c = c.validate()
u, err := url.Parse(fmt.Sprintf("https://%s/search?q=%s", c.BaseURL, query))
u, err := url.Parse(fmt.Sprintf("https://%s/search", c.BaseURL))
if err != nil {
return nil, fmt.Errorf("invalid url: %w", err)
}
vals := u.Query()
vals.Set("q", query)
if c.Language != "" {
u.Query().Set("hl", c.Language)
vals.Set("hl", c.Language)
}
if c.Country != "" {
@@ -84,10 +87,12 @@ func (c Config) Search(ctx context.Context, b extractor.Browser, query string) (
}
if country != "" {
u.Query().Set("cr", country)
vals.Set("cr", country)
}
}
u.RawQuery = vals.Encode()
doc, err := b.Open(ctx, u.String(), extractor.OpenPageOptions{})
if err != nil {

View File

@@ -0,0 +1,39 @@
package google
import (
"testing"
)
func TestConfig_Validate_Defaults(t *testing.T) {
c := Config{}
c = c.validate()
if c.BaseURL != "google.com" {
t.Errorf("BaseURL = %q, want %q", c.BaseURL, "google.com")
}
if c.Language != "en" {
t.Errorf("Language = %q, want %q", c.Language, "en")
}
if c.Country != "us" {
t.Errorf("Country = %q, want %q", c.Country, "us")
}
}
func TestConfig_Validate_Preserves(t *testing.T) {
c := Config{
BaseURL: "google.co.uk",
Language: "fr",
Country: "uk",
}
c = c.validate()
if c.BaseURL != "google.co.uk" {
t.Errorf("BaseURL = %q, want %q", c.BaseURL, "google.co.uk")
}
if c.Language != "fr" {
t.Errorf("Language = %q, want %q", c.Language, "fr")
}
if c.Country != "uk" {
t.Errorf("Country = %q, want %q", c.Country, "uk")
}
}